Wireshark-commits: [Wireshark-commits] master 38657fa: epan: Restrict detect trailing stray charact

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 04 Sep 2018 17:42:57 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=38657fad58034ff5557caef10ef679b4ac404dbd
Submitter: "Stig Bjørlykke <stig@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

38657fa by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    epan: Restrict detect trailing stray characters in strings
    
    Only detect trailing string characters in FT_STRING, FT_STRINGZ and
    FT_STRINGZPAD, and when ENC_ASCII or ENC_UTF_8 (for now).
    
    Support for checking other encodings can be added later.
    
    Bug: 15105
    Change-Id: Ib7b61f65e4f99f85998937e843ad5312c6b03a28
    Reviewed-on: https://code.wireshark.org/review/29411
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  77b4b93   ntp: make ntp.precision an uint8.
     add  38657fa   epan: Restrict detect trailing stray characters in strings


Summary of changes:
 epan/proto.c | 34 +++++++++++++++++++++-------------
 1 file changed, 21 insertions(+), 13 deletions(-)