Wireshark-commits: [Wireshark-commits] master cb002c5: Qt: Avoid crash for ByteViewTab with 0 bytes

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 02 Sep 2018 18:21:37 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=cb002c597a4e4635b1743cb178301dc46b7d01de
Submitter: "Stig Bjørlykke <stig@xxxxxxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

cb002c5 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    Qt: Avoid crash for ByteViewTab with 0 bytes
    
    A ByteViewTab with 0 bytes is not useful, but may happen.
    The crash could be reproduced with the following Lua code:
    
      local t = ByteArray.new():tvb()
    
    Change-Id: I256fd7fc2b91aa3c1161c46558c647308a3d564b
    Reviewed-on: https://code.wireshark.org/review/29383
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Reviewed-by: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    

Actions performed:

    from  3ce847e   sharkd: Fix frames request for empty "" filter
     add  cb002c5   Qt: Avoid crash for ByteViewTab with 0 bytes


Summary of changes:
 ui/qt/byte_view_tab.cpp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)