Wireshark-commits: [Wireshark-commits] master 5c36f61: epan: Detect trailing stray characters in st

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 31 Aug 2018 05:22:15 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5c36f6166c30b586be3e6cc600f58e1eb5830eb7
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

5c36f61 by Stig Bjørlykke (stig@xxxxxxxxxxxxx):

    epan: Detect trailing stray characters in strings
    
    Trailing stray characters will not show up in the packet tree item
    when the string is correctly null terminated. This expert info
    will indicate when this occurs, typically from wrongly implemented
    protocol encoders.
    
    This will warn about cases like:
    
      tvb = "foo\0bar"
      proto_tree_add_item(..., tvb, 0, 7, ...)
    
    Change-Id: I66b9d3ba7bb3e45f1f6e492fa6916b29c9ee9ca4
    Reviewed-on: https://code.wireshark.org/review/29310
    Petri-Dish: Stig Bjørlykke <stig@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  888684e   lwm2mtlv: Register resource subtree array
     add  5c36f61   epan: Detect trailing stray characters in strings


Summary of changes:
 epan/proto.c | 61 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 59 insertions(+), 2 deletions(-)