URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=efb84bb30894465f6435c031eaac271fd0c2c8f7
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark
Commits:
efb84bb by Martin Kaiser (wireshark@xxxxxxxxx):
ppp: disable USB heuristic subdissector by default
Disable the PPP over USB heuristic subdisector by default.
Clarify the comment about "compressed" address and control fields. Compressed
means absent in this case. Therefore, the heuristic check for PPP over USB
comes down to checking that the first byte is 0x7e. This is too weak and produces
lots of false positives.
Change-Id: Idf2fa41ac2b9e46ec982c9d0ebbea0e72ec0e21b
Reviewed-on: https://code.wireshark.org/review/29322
Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
Petri-Dish: Martin Kaiser <wireshark@xxxxxxxxx>
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from bf02537 ppp: remove a variable that is always 0
add efb84bb ppp: disable USB heuristic subdissector by default
Summary of changes:
epan/dissectors/packet-ppp.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)