Wireshark-commits: [Wireshark-commits] master b7a6a11: Qt: fix several crashes in the SCTP Dialogs

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 20 Aug 2018 05:01:17 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b7a6a11376c75f02b827a3dbd7598ecf419f6151
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

b7a6a11 by Vasil Velichkov (vvvelichkov@xxxxxxxxx):

    Qt: fix several crashes in the SCTP Dialogs
    
    Store the association id instead of a pointer to the volatile
    "sctp_assoc_info_t" structure because it gets freed after a rescan.
    
    Bug: 14970
    Change-Id: Id8fe2dfe3549bd711fc8ddef0770b217e83c2088
    Fixes: v1.11.3-rc1-604-g796bf409b0 ("Add dialogs and graphs to analyse SCTP behavior similar to the GTK version.")
    Reviewed-on: https://code.wireshark.org/review/28711
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  aef6223   [Automatic update for 2018-08-19]
     add  b7a6a11   Qt: fix several crashes in the SCTP Dialogs


Summary of changes:
 ui/qt/main_window_slots.cpp            |  8 +++--
 ui/qt/sctp_all_assocs_dialog.cpp       | 47 +++++--------------------
 ui/qt/sctp_all_assocs_dialog.h         |  4 +--
 ui/qt/sctp_assoc_analyse_dialog.cpp    | 64 +++++++++++++++++++++-------------
 ui/qt/sctp_assoc_analyse_dialog.h      | 14 ++++----
 ui/qt/sctp_chunk_statistics_dialog.cpp | 22 +++++++++---
 ui/qt/sctp_chunk_statistics_dialog.h   | 10 +++---
 ui/qt/sctp_graph_arwnd_dialog.cpp      | 26 ++++++++------
 ui/qt/sctp_graph_arwnd_dialog.h        |  9 ++---
 ui/qt/sctp_graph_byte_dialog.cpp       | 25 ++++++++-----
 ui/qt/sctp_graph_byte_dialog.h         |  7 ++--
 ui/qt/sctp_graph_dialog.cpp            | 56 ++++++++++++++++++-----------
 ui/qt/sctp_graph_dialog.h              | 13 +++----
 ui/tap-sctp-analysis.c                 |  6 ++++
 ui/tap-sctp-analysis.h                 |  2 +-
 15 files changed, 173 insertions(+), 140 deletions(-)