Wireshark-commits: [Wireshark-commits] master 3d9534d: WireGuard: fix null-deref in wg_dissect_hand

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 09 Aug 2018 18:56:59 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=3d9534d0eecd409c907e54d6d5a87a90ec36f60f
Submitter: "Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>"
Changed: branch: master
Repository: wireshark

Commits:

3d9534d by Peter Wu (peter@xxxxxxxxxxxxx):

    WireGuard: fix null-deref in wg_dissect_handshake_initiation
    
    session can be NULL if no valid session was found in the first pass.
    Reproduced crash with attachment 16534 from bug 15050.
    
    Change-Id: I45b9fcc4bfeb79b00075f70417acb17c2e4aede2
    Fixes: v2.9.0rc0-1389-g5b61737dc9 ("WireGuard: implement initiation message decryption with static keys")
    Reviewed-on: https://code.wireshark.org/review/29047
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    

Actions performed:

    from  bc6e462   GTPv2: add dissection of newer geographic location types
     add  3d9534d   WireGuard: fix null-deref in wg_dissect_handshake_initiation


Summary of changes:
 epan/dissectors/packet-wireguard.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)