Wireshark-commits: [Wireshark-commits] master-2.6 f9e8b0f: Qt: fix crash on switching profiles

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 09 Aug 2018 04:50:30 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=f9e8b0fa42dbec5550d0fc4c78fa32b342d78baf
Submitter: "Anders Broman <a.broman58@xxxxxxxxx>"
Changed: branch: master-2.6
Repository: wireshark

Commits:

f9e8b0f by Peter Wu (peter@xxxxxxxxxxxxx):

    Qt: fix crash on switching profiles
    
    Switching from the Default profile to the Bluetooth one increases the
    number of columns. While "prefs.num_cols" is incremented in
    column_format_set_cb, the actual column definition is only defined in
    build_column_format_array (via WiresharkApplication::columnsChanged).
    Do not call packet_list_enable_color in between as that will make the
    packet list model access the column information.
    
    2.4 is unaffected, master is already fixed via commit 5e7cd2dfc6 (which
    cannot directly be backported due to missing GTK+ changes).
    
    Change-Id: I9fd14ed2f56123d881334e373101df816e144b52
    Reviewed-on: https://code.wireshark.org/review/29032
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  1576ae1   802.11 Radiotap: add more bound checks in ieee80211_radiotap_iterator_next()
     add  f9e8b0f   Qt: fix crash on switching profiles


Summary of changes:
 ui/qt/wireshark_application.cpp | 1 -
 1 file changed, 1 deletion(-)