URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=090ed6ed6b42312b5ed52264ed63a341f3de1f8a
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark
Commits:
090ed6e by Vadim Yanitskiy (axilirator@xxxxxxxxx):
[GSM A RR]: fix: properly dissect APDU Flags for Application Info
According to 3GPP TS 04.08, section 10.5.2.49, the APDU Flags field
is coded together with APDU ID, and occupies bits 1-3 (mask 0x70):
0 1 2 3
S T F L
. . . * Last Segment
. . * . First Segment
. * . . C/R, if L=0 only, otherwise spare and set to 0
* . . . Spare (0)
Instead of parsing all bits together as a set of integer values,
let's parse each flag individually. Moreover, the previous
definition was missing some possible bit combinations, so
this change also fixes that problem.
Change-Id: Id71fae9ef06572c1ad17aafe0be3dfb66e081b7d
Reviewed-on: https://code.wireshark.org/review/28948
Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
Reviewed-on: https://code.wireshark.org/review/28957
Actions performed:
from 5a22432 [GSM A RR]: fix APDU ID/Flags parsing for Application Info
add 090ed6e [GSM A RR]: fix: properly dissect APDU Flags for Application Info
Summary of changes:
epan/dissectors/packet-gsm_a_rr.c | 41 ++++++++++++++++++++++++++++++---------
1 file changed, 32 insertions(+), 9 deletions(-)