Wireshark-commits: [Wireshark-commits] master 75d4fac: No need to tell the BER dissector the file n

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 01 Aug 2018 06:25:10 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=75d4fac5f9163080eb442ae54c8ddbf526b8867f
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

75d4fac by Guy Harris (guy@xxxxxxxxxxxx):

    No need to tell the BER dissector the file name for RFC 7468 files.
    
    It's just a hack for "raw BER data" files, giving them a file name that
    includes the OID to use for the syntax.  For RFC 7468 files, the syntax
    is determined from the label in the pre-encapsulation boundary.
    
    Change-Id: Ia656f20f123d2c6a85041f83714a3a1cfefb70b1
    Reviewed-on: https://code.wireshark.org/review/28916
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  24e44a6   Don't hide dissected data under a "Data" item.
    adds  75d4fac   No need to tell the BER dissector the file name for RFC 7468 files.


Summary of changes:
 file.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)