Wireshark-commits: [Wireshark-commits] master 9cf292a: Revert "Have find_or_create_conversation() u

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 01 Aug 2018 02:55:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9cf292a30f0098c9abcef57d9242cbc2d00e5075
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

9cf292a by Guy Harris (guy@xxxxxxxxxxxx):

    Revert "Have find_or_create_conversation() use pinfo->conv_endpoint if present."
    
    This reverts commit ba202ef36225b59eb797c5a48b8d4a4665b479c7.
    
    Creating endpoints, and corresponding conversations, for protocols atop which TCP or UDP runs can potentially cause attempts to look up the conversation to find the conversation for that protocol rather than for TCP/UDP, which can confuse protocols running atop TCP or UDP.
    
    Change-Id: I3ca522e54e67cc4f996d0ee841c6bb40ee6a9976
    Reviewed-on: https://code.wireshark.org/review/28912
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  b28345b   Get rid of a no-longer-used dissector handle.
    adds  9cf292a   Revert "Have find_or_create_conversation() use pinfo->conv_endpoint if present."


Summary of changes:
 debian/libwireshark0.symbols  |  2 +-
 epan/conversation.c           | 46 +++++++++++++++++++++----------------------
 epan/conversation.h           |  9 ++++++---
 epan/dissectors/packet-isdn.c |  5 ++---
 4 files changed, 32 insertions(+), 30 deletions(-)