Wireshark-commits: [Wireshark-commits] master 8f56eb5: TDS: Fix bad proto_tree_add_item_ret_string_

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 31 Jul 2018 06:20:48 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8f56eb5d00ec08b18e559d459566ca5fcbb53328
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

8f56eb5 by Craig Jackson (cejackson51@xxxxxxxxx):

    TDS: Fix bad proto_tree_add_item_ret_string_and_length call.
    
    I'm not sure why this compiled in all of the test environments. (Ubuntu and Windows, plus Buildbot.)
    
    Change-Id: I15d281010f3f463f3929aff8918ade8b71cffff7
    Reviewed-on: https://code.wireshark.org/review/28887
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  46cb956   sccp: Make "lr" a generated item rather than hidden to make it obvious that it exists.
    adds  8f56eb5   TDS: Fix bad proto_tree_add_item_ret_string_and_length call.


Summary of changes:
 epan/dissectors/packet-tds.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)