Wireshark-commits: [Wireshark-commits] master-2.4 7ef10d6: If the dissector isn't registered, you s

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sun, 22 Jul 2018 19:21:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7ef10d6646235afb94db45aa2521b5a298531624
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

7ef10d6 by Guy Harris (guy@xxxxxxxxxxxx):

    If the dissector isn't registered, you shouldn't be calling it.
    
    Report a dissector bug, rather than calling the data dissector.
    
    Change-Id: I7bde1001a48d2443acf2dc7caa83434e0972aab7
    Reviewed-on: https://code.wireshark.org/review/28814
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 954fe24e418723df7bac6be146528947ca11d060)
    Reviewed-on: https://code.wireshark.org/review/28816
    

Actions performed:

    from  4be2480   Don't assume a given btgatt.uuid0xXXXX dissector exists.
    adds  7ef10d6   If the dissector isn't registered, you shouldn't be calling it.


Summary of changes:
 epan/dissectors/packet-btatt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)