Wireshark-commits: [Wireshark-commits] master 6dc8e11: CIP Motion: Update attribute service handlin

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 13 Jul 2018 12:57:47 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6dc8e11d8dd01e4392d83618df0ceed4db3629ae
Submitter: Roland Knall (rknall@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

6dc8e11 by Dylan Ulis (daulis0@xxxxxxxxx):

    CIP Motion: Update attribute service handling
    
    1. Get/Set Axis Attribute List: Display the attribute name, and dissect where appropriate.
    2. Minor: Cleanup exported functions/variables.
    
    Bug: 14958
    Change-Id: I2ff6883e66068472ac5ded0172f51575f5e20a21
    Reviewed-on: https://code.wireshark.org/review/28660
    Petri-Dish: Roland Knall <rknall@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Roland Knall <rknall@xxxxxxxxx>
    

Actions performed:

    from  78f7df3   LTE RRC: upgrade dissector to v15.2.2
    adds  6dc8e11   CIP Motion: Update attribute service handling


Summary of changes:
 epan/dissectors/packet-cip.c       |  28 ++++------
 epan/dissectors/packet-cip.h       |  62 ++++++++++++++-------
 epan/dissectors/packet-cipmotion.c | 109 +++++++++++++++++++++++++++----------
 3 files changed, 131 insertions(+), 68 deletions(-)