URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e56148c4434f43790d07d5da1af7971320279e48
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark
Commits:
e56148c by Peter Wu (peter@xxxxxxxxxxxxx):
Follow Stream: ensure linear performance with many packets
Reverse the payload chunks list to achieve a running time of O(n) rather
than O(n²) for insertion of all chunks. Executing a RelWithDebInfo+ASAN
build with `tshark -r chargen-session.pcapng.gz -qz follow,tcp,hex,0`
previously took 11m5s to complete, but now finishes in 16 seconds.
Tested using a capture file with 152k TCP packets (from bug 11777).
Backport note: must update ui/gtk/follow_stream.c too.
Change-Id: Icf70d45f33d4399e53209fb6199d3809608c8d99
Reviewed-on: https://code.wireshark.org/review/28595
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
(cherry picked from commit c40c26c04c6a39ef7867a35c50293c666255c9a4)
[Peter: updated ui/gtk/follow_stream.c for master-2.6]
Reviewed-on: https://code.wireshark.org/review/28642
Actions performed:
from 7656827 Plug extension list leak.
adds e56148c Follow Stream: ensure linear performance with many packets
Summary of changes:
epan/dissectors/packet-ssl.c | 4 ++--
epan/dissectors/packet-tcp.c | 10 +++++-----
epan/follow.c | 4 ++--
epan/follow.h | 2 +-
sharkd_session.c | 2 +-
ui/cli/tap-follow.c | 4 ++--
ui/gtk/follow_stream.c | 2 +-
ui/qt/follow_stream_dialog.cpp | 2 +-
8 files changed, 15 insertions(+), 15 deletions(-)