Wireshark-commits: [Wireshark-commits] master 238c7dd: Don't use QFileInfo()::baseName().

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 06 Jul 2018 09:47:17 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=238c7dd61d3de89b9341655625547a404708b396
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

238c7dd by Guy Harris (guy@xxxxxxxxxxxx):

    Don't use QFileInfo()::baseName().
    
    It strips off all suffixes, which is not useful behavior; it assumes
    that nobody uses "." for any purpose other than separating a file name
    from an extension - 1994 called, they want their version of Windows
    back (and UN*X called, too...).
    
    For the "Saving XXX" status bar message, just use the entire last
    component of the file name.
    
    Change-Id: Ib34fde3e49cd791c7baf333eebb71a8dbd672c19
    Reviewed-on: https://code.wireshark.org/review/28638
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  aab5ad0   Fix the calculation of a file's "basename".
    adds  238c7dd   Don't use QFileInfo()::baseName().


Summary of changes:
 ui/qt/main_window_slots.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)