URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=59192f79fc226b77ef71b9012e0e867002882aaf
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
59192f7 by Peter Wu (peter@xxxxxxxxxxxxx):
tcp: ignore zero-length payloads for Follow TCP Stream
In the Qt Follow TCP Stream dialog with the ASCII mode, sometimes
selecting the first few bytes would wrongly select a packet with a
higher frame number.
This happens because Qt iterates through the list of payloads, then
stores appends the payload data and maps the new cursor position to the
packet number. If the payload data was empty, then it would overwrite
previous cursor positions.
To fix this, do not add records for empty TCP payloads.
Bug: 14898
Change-Id: I598d73899b56eac3d2a022f108bf097bdd363b5c
Reviewed-on: https://code.wireshark.org/review/28613
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from aecb143 tcp: fix Follow TCP Stream for overlapping data
adds 59192f7 tcp: ignore zero-length payloads for Follow TCP Stream
Summary of changes:
epan/dissectors/packet-tcp.c | 28 ++++++++--------------------
1 file changed, 8 insertions(+), 20 deletions(-)