Wireshark-commits: [Wireshark-commits] master-2.6 6ced31d: CaptureFile.fileTitle() is for display,

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 03 Jul 2018 22:41:35 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=6ced31d22337e7da78dabd984d22a4bb01a0a0c4
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

6ced31d by Guy Harris (guy@xxxxxxxxxxxx):

    CaptureFile.fileTitle() is for display, not for file name processing.
    
    Don't use CaptureFile.fileTitle() if you're constructing a pathname; use
    it only if you're constructing a window title.
    
    Change-Id: I40f225ddb07be2f7dc3ae03108dae816846f20c7
    Reviewed-on: https://code.wireshark.org/review/28582
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit d76db1de783dca7fd99d7e663d7be4031ae426de)
    Reviewed-on: https://code.wireshark.org/review/28583
    

Actions performed:

    from  e968bd8   file: add more sanity checks to detect UI/file loading issues
    adds  6ced31d   CaptureFile.fileTitle() is for display, not for file name processing.


Summary of changes:
 ui/qt/iax2_analysis_dialog.cpp | 2 +-
 ui/qt/io_graph_dialog.cpp      | 2 +-
 ui/qt/rtp_analysis_dialog.cpp  | 2 +-
 ui/qt/rtp_stream_dialog.cpp    | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)