Wireshark-commits: [Wireshark-commits] master 2f4cdb9: file: add more sanity checks to detect UI/fi

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 03 Jul 2018 07:58:31 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2f4cdb97c7085bad56cce68dd00c9d0092a12dc9
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2f4cdb9 by Peter Wu (peter@xxxxxxxxxxxxx):

    file: add more sanity checks to detect UI/file loading issues
    
    As "cf_read" and "rescan_packets" can end up calling back to the GUI
    code, that could destroy "cf->epan" which could result in use-after-free
    crashes. While I can find most issues with ASAN, it would be even
    better to detect the destructive action in "cf_close".
    
    Change-Id: I72700a60c6786d153c2aaa8478bfdfb16a01dcda
    Ping-Bug: 10870
    Reviewed-on: https://code.wireshark.org/review/28542
    Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  536e26c   Qt: fix crash on opening a capture file while loading/saving another
    adds  2f4cdb9   file: add more sanity checks to detect UI/file loading issues


Summary of changes:
 file.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)