Wireshark-commits: [Wireshark-commits] master 1600a7d: Check the address type, not the address leng

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 20 Jun 2018 20:50:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=1600a7d9f8d5ec51336b3dbd83850756565eb6ca
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

1600a7d by Guy Harris (guy@xxxxxxxxxxxx):

    Check the address type, not the address length, in multicast/broadcast tests.
    
    The tests assume an IPv4 address; check for IPv4 addresses.  They're
    always 4 octets long, so no need to check the length.
    
    Change the XXX comment to ask whether the check for an IPv4 address is
    even necessary.
    
    Change-Id: Ic55d2c208d5472ec995aa0c150b09a2118f04a76
    Reviewed-on: https://code.wireshark.org/review/28353
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  50c1900   MAC NR: upgrade dissector to v15.2.0
    adds  1600a7d   Check the address type, not the address length, in multicast/broadcast tests.


Summary of changes:
 epan/dissectors/packet-icmp.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)