Wireshark-commits: [Wireshark-commits] master 27a1906: RTP: Code clean up

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 19 Jun 2018 15:05:23 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=27a1906c582b9c7dcd17e7db2726a1059e3aaf8a
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

27a1906 by Jiri Novak (j.novak@xxxxxxxxxxxx):

    RTP: Code clean up
    
    Changes:
    - rtpstream_packet renamed to rtpstream_packet_cb to follow *_cb pattern
    - variables/types used in iax2_analysis_dialog were created as copy of *rtp* ones, but names were left as *rtp* -> *iax2*
    - struct _rtp_stream_info replaced with rtp_stream_info_t
    - there was tap-rtp-analysis.h, but no tap-rtp-analysis.c - related content was moved from tap-rtp-common.c
    - *rtp_stream* functions renamed to *rtpstream*
    - renamed rtp_stream_info_t to rtpstream_info_t to follow *rtpstream* pattern.
    - renamed ui/rtp_stream.c rtpstream_draw -> rtpstream_draw_cb
    
    Change-Id: Ib11ff5367cc464ea1b0c73432bc50b0eb9cd203e
    Reviewed-on: https://code.wireshark.org/review/28299
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  434fbe2   Updating T6aT6b specific DIAMETER AVPs per 29.128 15.3
    adds  27a1906   RTP: Code clean up


Summary of changes:
 sharkd_session.c                            |   7 +-
 ui/CMakeLists.txt                           |   1 +
 ui/cli/tap-rtp.c                            |   6 +-
 ui/qt/iax2_analysis_dialog.cpp              |   4 +-
 ui/qt/rtp_analysis_dialog.cpp               |  18 +-
 ui/qt/rtp_analysis_dialog.h                 |  12 +-
 ui/qt/rtp_audio_stream.cpp                  |   8 +-
 ui/qt/rtp_audio_stream.h                    |  10 +-
 ui/qt/rtp_player_dialog.cpp                 |   4 +-
 ui/qt/rtp_player_dialog.h                   |   6 +-
 ui/qt/rtp_stream_dialog.cpp                 |  36 +--
 ui/qt/voip_calls_dialog.cpp                 |   4 +-
 ui/rtp_media.c                              |   1 +
 ui/rtp_stream.c                             |  28 +-
 ui/rtp_stream.h                             |  18 +-
 ui/tap-iax2-analysis.h                      |   4 +-
 ui/{tap-rtp-common.c => tap-rtp-analysis.c} | 261 +---------------
 ui/tap-rtp-analysis.h                       |   6 +-
 ui/tap-rtp-common.c                         | 466 +---------------------------
 ui/tap-rtp-common.h                         |  15 +-
 ui/voip_calls.c                             |  20 +-
 21 files changed, 123 insertions(+), 812 deletions(-)
 copy ui/{tap-rtp-common.c => tap-rtp-analysis.c} (65%)