URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=bef062e56e458006b71c612717dccd32517bc459
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
bef062e by Dylan Ulis (daulis0@xxxxxxxxx):
CIP: Improve I/O handling
1. Add new dissector table that allows for registration of CIP Class 0/1 I/O
against CIP Class that was used in the Forward Open. CIP Safety is still
a special case that gets checked before this table. The default handling is
generic CIP Class 0/1 I/O.
2. Changed most I/O items labelled "ENIP" to "CIP I/O". ENIP is a separate
protocol/layer, and all the I/O traffic is actually CIP. It was very
confusing explaining to people they had to look at the wrong protocol
layer in Wireshark before.
3. Add the generic Class 0/1 I/O as a separate tree layer. CIP Motion and
CIP Safety I/O were already doing this.
4. Update CIP conversation filtering naming to be more accurate.
5. Clean up some offset handling
Change-Id: I1c226fe1bd8974ed0e90640c875bef21f15f3095
Reviewed-on: https://code.wireshark.org/review/28290
Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 333e915 Better name for the routine.
adds bef062e CIP: Improve I/O handling
Summary of changes:
epan/dissectors/packet-cip.c | 6 +--
epan/dissectors/packet-cip.h | 3 +-
epan/dissectors/packet-cipmotion.c | 28 ++++++++--
epan/dissectors/packet-cipsafety.c | 12 +++--
epan/dissectors/packet-enip.c | 107 +++++++++++++++++++++++--------------
epan/dissectors/packet-enip.h | 6 ++-
6 files changed, 106 insertions(+), 56 deletions(-)