Wireshark-commits: [Wireshark-commits] master-2.4 169d271: HTTP2: prevent a segmentation fault if H

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 13 Jun 2018 12:38:05 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=169d271f1f03a5b21d13579995421599a8535def
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

169d271 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    HTTP2: prevent a segmentation fault if HTTP2 dissector was not called on first pass
    
    With HTTP2 heuristics to identify the conversation, a packet can be
    skipped on first pass and then decoded as HTTP2 on subsequent ones.
    Check that header data is available before attempting header
    decompression.
    
    Bug: 14869
    Change-Id: I8ef7669ca33835b509acb38d797e33d6167a1bd1
    Reviewed-on: https://code.wireshark.org/review/28257
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    (cherry picked from commit e281ca6f83560a24ac1d490dcca9fe49b03bbdcd)
    Conflicts:
    	epan/dissectors/packet-http2.c
    Reviewed-on: https://code.wireshark.org/review/28260
    

Actions performed:

    from  56e9dab   Make sure *both* sides are unsigned.
    adds  169d271   HTTP2: prevent a segmentation fault if HTTP2 dissector was not called on first pass


Summary of changes:
 epan/dissectors/packet-http2.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)