Wireshark-commits: [Wireshark-commits] master-2.4 82a17ff: Fix signed vs. unsigned comparison warni

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 12 Jun 2018 22:17:00 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=82a17ff5b1c503e38c1b17b565186c1e6df1c882
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

82a17ff by Guy Harris (guy@xxxxxxxxxxxx):

    Fix signed vs. unsigned comparison warning.
    
    (In retrospect, signed offsets probably were the wrong choice; we
    rarely, if ever, use them to signify offsets from the end of the packet.
    Let's not do so any more in the future.)
    
    Change-Id: I7ace539be8bf927e21148c34b71e9c2b7535581e
    Reviewed-on: https://code.wireshark.org/review/28245
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 96c4655ae088c5162799df3b799696b6dece814f)
    Reviewed-on: https://code.wireshark.org/review/28247
    

Actions performed:

    from  96af0ad   Add some length checks, remove a DISSECTOR_ASSERT().
    adds  82a17ff   Fix signed vs. unsigned comparison warning.


Summary of changes:
 epan/crypt/airpdcap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)