Wireshark-commits: [Wireshark-commits] master-2.4 67fee7e: Use FT_NONE, not FT_STRINGZ, for the fie

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 09 Jun 2018 22:51:43 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=67fee7eb8ebd065b8230bf0cc345eb5ae92b4b17
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

67fee7e by Guy Harris (guy@xxxxxxxxxxxx):

    Use FT_NONE, not FT_STRINGZ, for the field that covers the packet.
    
    They're collections of binary data divided into subfields, not
    null-terminated strings, so give them the right type.
    
    Change-Id: If2685b9b41ca6711e12de6688ae51d5211767770
    Reviewed-on: https://code.wireshark.org/review/28175
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 33eb5e73ddd61b27621eb1e821c7864d95f2cbc9)
    Reviewed-on: https://code.wireshark.org/review/28177
    

Actions performed:

    from  09cd0fe   Fix handling of text headers with non-text values.
    adds  67fee7e   Use FT_NONE, not FT_STRINGZ, for the field that covers the packet.


Summary of changes:
 epan/dissectors/packet-cigi.c | 208 +++++++++++++++++++++---------------------
 1 file changed, 104 insertions(+), 104 deletions(-)