Wireshark-commits: [Wireshark-commits] master-2.4 5e1d4bb: Make the string representation of the fr

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 08 Jun 2018 23:17:09 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=5e1d4bb8f0889e34457832e330a4874d988586fe
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

5e1d4bb by Guy Harris (guy@xxxxxxxxxxxx):

    Make the string representation of the frame bitmap cover the frame bitmap.
    
    Make it begin where the frame bitmap begins, and end where the frame
    bitmap ends, rather than pretending it begins where the frame bitmap
    *ends* and is as many bytes long as the generated string is.
    
    Change-Id: Id62ba067116e3191646af764d3ae846474ac29c8
    Reviewed-on: https://code.wireshark.org/review/28160
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 89540b9cba201855385fd90d1bffec270bf74ce9)
    Reviewed-on: https://code.wireshark.org/review/28162
    

Actions performed:

    from  ac8d875   The string part of a NULL string is zero bytes long, not 4 bytes long.
    adds  5e1d4bb   Make the string representation of the frame bitmap cover the frame bitmap.


Summary of changes:
 epan/dissectors/packet-t30.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)