Wireshark-commits: [Wireshark-commits] master-2.2 194d0d2: The string part of a NULL string is zero

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 08 Jun 2018 21:06:43 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=194d0d2bf2fc295cbb41746633e9d1cfe612594b
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

194d0d2 by Guy Harris (guy@xxxxxxxxxxxx):

    The string part of a NULL string is zero bytes long, not 4 bytes long.
    
    There aren't 4 bytes of 'N', 'U', 'L', and 'L' in the packet, so the
    length is *not* 4 bytes.
    
    Change-Id: I81331ef3f307dc65458da37e7d46e299eb7e727a
    Reviewed-on: https://code.wireshark.org/review/28149
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 09a7e8e863ac8a3b80a7a016b9943f815fc92367)
    Reviewed-on: https://code.wireshark.org/review/28152
    

Actions performed:

    from  768544f   stats_tree: fix this statement may fall through [-Werror=implicit-fallthrough] found by gcc7
    adds  194d0d2   The string part of a NULL string is zero bytes long, not 4 bytes long.


Summary of changes:
 epan/dissectors/packet-mysql.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)