Wireshark-commits: [Wireshark-commits] master-2.6 ae43f03: Don't check the CRC if the message isn't

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 31 May 2018 17:24:01 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ae43f03f7f146a121986a2e57672bac1aa2948e1
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

ae43f03 by Guy Harris (guy@xxxxxxxxxxxx):

    Don't check the CRC if the message isn't big enough to have a CRC.
    
    We should really do a better length check.  This also suggests that we
    might be going past the length if it's too short - should we create a
    new tvbuff, with tvb_subset_length(), and dissect based on that?
    
    Bug: 14780
    Change-Id: Iaaab529f34b0168ad74c7b4f3e1b4255504c1b57
    Reviewed-on: https://code.wireshark.org/review/27930
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 00f51fef21288100ee5b47aa51610533966de35a)
    Reviewed-on: https://code.wireshark.org/review/27931
    

Actions performed:

    from  cad7c8e   autotools: Use CC_FOR_BUILD with make-taps and make-dissectors
    adds  ae43f03   Don't check the CRC if the message isn't big enough to have a CRC.


Summary of changes:
 plugins/epan/wimax/wimax_harq_map_decoder.c | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)