URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=8da47774405e1df46fabdc23640820b888a767ac
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
8da4777 by Peter Wu (peter@xxxxxxxxxxxxx):
Qt: fix memleaks on opening a context menu
FrameInformation was never deallocated, leaking the whole pinfo scope.
Fix a dealloc-alloc-mismatch (packet_data_ was g_memdup'd). Attach the
DataPrinter menu actions to the action group instead of the singleton
DataPrinter instance, this enables freeing the actions when the submenu
is gone rather than clearing this at program exit.
Reported by ASAN.
Change-Id: If13af94a60b07b0e52973ccc5c437ef987bfb394
Fixes: v2.5.0rc0-1627-g8a6ea0e454 ("Qt: Further cleanup ByteView")
Reviewed-on: https://code.wireshark.org/review/27844
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 349c3aa Qt: fix memleaks in protocol preferences menu
adds 8da4777 Qt: fix memleaks on opening a context menu
Summary of changes:
ui/qt/packet_list.cpp | 3 +++
ui/qt/utils/data_printer.cpp | 18 ++++++------------
ui/qt/utils/frame_information.cpp | 2 +-
3 files changed, 10 insertions(+), 13 deletions(-)