Wireshark-commits: [Wireshark-commits] master-2.4 04c44d8: Fix test for early exit from MMSE dissec

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 29 May 2018 00:26:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=04c44d89c988c17fd6343353673188deb844cb50
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

04c44d8 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix test for early exit from MMSE dissector.
    
    We don't need to dissect the body if 1) we're *not* building a protocol
    tree (tree == NULL) *and* 2) the PDU doesn't have content that can be
    handed off to subdissectors.
    
    (Fix which vs. that issue in a comment while we're at it.)
    
    Change-Id: I90890975c05e72cc9ebc776a21683905828f57b5
    Reviewed-on: https://code.wireshark.org/review/27876
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 91c069d5b3dd4736653287a9e454b06354564011)
    Reviewed-on: https://code.wireshark.org/review/27886
    

Actions performed:

    from  768a021   mmse: remove a ton of if (tree) checks
    adds  04c44d8   Fix test for early exit from MMSE dissector.


Summary of changes:
 epan/dissectors/packet-mmse.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)