Wireshark-commits: [Wireshark-commits] master-2.6 0109a15: Fix test for early exit from MMSE dissec

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 28 May 2018 18:24:06 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=0109a15956a15c0b5b0971d88f0599e0c2e7aa6b
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

0109a15 by Guy Harris (guy@xxxxxxxxxxxx):

    Fix test for early exit from MMSE dissector.
    
    We don't need to dissect the body if 1) we're *not* building a protocol
    tree (tree == NULL) *and* 2) the PDU doesn't have content that can be
    handed off to subdissectors.
    
    (Fix which vs. that issue in a comment while we're at it.)
    
    Change-Id: I90890975c05e72cc9ebc776a21683905828f57b5
    Reviewed-on: https://code.wireshark.org/review/27876
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 91c069d5b3dd4736653287a9e454b06354564011)
    Reviewed-on: https://code.wireshark.org/review/27877
    

Actions performed:

    from  d8a077c   GTK: fix compilation error introduced in ga42dbe842c
    adds  0109a15   Fix test for early exit from MMSE dissector.


Summary of changes:
 epan/dissectors/packet-mmse.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)