Wireshark-commits: [Wireshark-commits] master-2.2 e401795: Creat protocol tvbuff before allocating

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 23 May 2018 03:44:30 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e401795233acfd82961aad698dace7fd90d2ab84
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

e401795 by Guy Harris (guy@xxxxxxxxxxxx):

    Creat protocol tvbuff before allocating and freeing memory.
    
    That way, if the attempt to create the protocol tvbuff throws an
    exception, we won't leak the protocol representation string, as we won't
    even try to allocate it.
    
    Bug: 14719
    Change-Id: Id2855bc97e71aa0682737d1a04486a2a01f5f1e6
    Reviewed-on: https://code.wireshark.org/review/27730
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 0f1f1d0ab827243d3e639ec1d00693e0d2edb883)
    Reviewed-on: https://code.wireshark.org/review/27733
    

Actions performed:

    from  296d91b   2.2.15 → 2.2.16.
    adds  e401795   Creat protocol tvbuff before allocating and freeing memory.


Summary of changes:
 epan/proto.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)