URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=e7056e6ce69c770bd4e6a1b0de2d0b658cd24d72
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
e7056e6 by Dylan Ulis (daulis0@xxxxxxxxx):
CIP: Code cleanup
1. Convert more things to proto_tree_add_bitmask
2. Remove unnecessary pathpos param everywhere
3. Replace some tvb_get_xxx with proto_tree_add_item_ret_uint
4. Remove unused variables, params
5. Remove if(tree)
There are no functional changes. In the area where there is a lot of
diff (eg: pathpos), I verified using the pcap from Bug: 12049, and
compared the PDML output before and after, just as a sanity check.
Change-Id: I9564172ccece558cf1877b667f713b584a00d73f
Reviewed-on: https://code.wireshark.org/review/27642
Petri-Dish: Anders Broman <a.broman58@xxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
Actions performed:
from 8ee56d2 Get rid of add_async_dns_ipv4().
adds e7056e6 CIP: Code cleanup
Summary of changes:
epan/dissectors/packet-cip.c | 403 ++++++++++++++++++-------------------
epan/dissectors/packet-cipsafety.c | 88 ++++----
epan/dissectors/packet-enip.c | 97 ++++-----
3 files changed, 282 insertions(+), 306 deletions(-)