Wireshark-commits: [Wireshark-commits] master 64ef1ca: radius: fix memleaks in dissect_attribute_va

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 17 May 2018 16:12:37 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=64ef1ca87fe2a73cd6b0798fd24c6727f13b2746
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

64ef1ca by Peter Wu (peter@xxxxxxxxxxxxx):

    radius: fix memleaks in dissect_attribute_value_pairs
    
    CLEANUP_PUSH_PFX with "eap_buffer" and "vsa_buffer_table" was
    ineffective because these pointers are initially NULL.
    
    Bug: 14429
    Change-Id: I5e6c457df714543bd384f93cdfa012f6122f9aa9
    Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=6279
    Reviewed-on: https://code.wireshark.org/review/27537
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
    

Actions performed:

    from  177ea9e   test: require Libgcrypt 1.6 for TDLS test
    adds  64ef1ca   radius: fix memleaks in dissect_attribute_value_pairs


Summary of changes:
 epan/dissectors/packet-radius.c | 24 ++++++++++++++++--------
 1 file changed, 16 insertions(+), 8 deletions(-)