Wireshark-commits: [Wireshark-commits] master d3427b8: megaco: fix issue found PVS Studio (V517)

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 16 May 2018 04:21:17 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=d3427b8a65d926ae4c85d0ec730eaf1a574041c3
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

d3427b8 by Alexis La Goutte (alexis.lagoutte@xxxxxxxxx):

    megaco: fix issue found PVS Studio (V517)
    
    The use of 'if (A) {...} else if (A) {...}' pattern was detected. There is a probability of logical error presence.
    
    Change-Id: Id3e4584d1cafebd6643dd97c21916ef6b1818d9d
    Reviewed-on: https://code.wireshark.org/review/27510
    Petri-Dish: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  4dc27d9   CMake 3.11.0 has problems on Lion; use 3.5.2, which works.
    adds  d3427b8   megaco: fix issue found PVS Studio (V517)


Summary of changes:
 epan/dissectors/packet-megaco.c | 6 ------
 1 file changed, 6 deletions(-)