Wireshark-commits: [Wireshark-commits] master-2.4 52f6497: You have to set tm_isdst before calling

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 09 May 2018 08:05:05 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=52f6497248f8fd6b4def89376b68faf73e3818ac
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

52f6497 by Guy Harris (guy@xxxxxxxxxxxx):

    You have to set tm_isdst before calling mktime().
    
    You either need to tell mktime() that 1) DST/Summer Time is in effect,
    2) DST/Summer Time isn't in effect, or 3) we don't know whether
    DST/Summer Time is in effect, you figure it out.
    
    We set tm_isdst to -1, to choose option 3), which is what we want.
    
    Fixes Coverity CID 1435496.
    
    Change-Id: I0f22ef1201ee8abefb3fa75aa3432b021fb13cfd
    Reviewed-on: https://code.wireshark.org/review/27408
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 4513c66b1a2c7f7feb729e7e4e576b390395a123)
    Reviewed-on: https://code.wireshark.org/review/27417
    

Actions performed:

    from  713599b3  You have to set tm_isdst before calling mktime().
    adds  52f6497   You have to set tm_isdst before calling mktime().


Summary of changes:
 extcap/androiddump.c | 2 ++
 1 file changed, 2 insertions(+)