Wireshark-commits: [Wireshark-commits] master-2.4 713599b3: You have to set tm_isdst before calling

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 09 May 2018 03:44:29 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=713599b32c0ed8967965a19a35e75a1df2853eec
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

713599b3 by Guy Harris (guy@xxxxxxxxxxxx):

    You have to set tm_isdst before calling mktime().
    
    You either need to tell mktime() that 1) DST/Summer Time is in effect,
    2) DST/Summer Time isn't in effect, or 3) we don't know whether
    DST/Summer Time is in effect, you figure it out.
    
    We set tm_isdst to -1, to choose option 3), which is what we want.
    
    Fixes Coverity CID 1435496.
    
    Change-Id: Iff24e51807ab42c0e6d9629f72848ad9f8d325fb
    Reviewed-on: https://code.wireshark.org/review/27404
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 270f0554d86ad5a7d6455f8eccbf057acdc69a91)
    Reviewed-on: https://code.wireshark.org/review/27406
    

Actions performed:

    from  01e7bcf   gtp, gtpv2: fix memory leaks in association code (found via ASAN)
    adds  713599b3  You have to set tm_isdst before calling mktime().


Summary of changes:
 epan/dissectors/packet-logcat-text.c | 1 +
 1 file changed, 1 insertion(+)