URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=b08022eaa093a44ff7eb2b8f454e2393b94cac71
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark
Commits:
b08022e by Peter Wu (peter@xxxxxxxxxxxxx):
tcp: fix memleak in Follow TCP tap in error cases
If this not the first data segment and the data is somehow empty
(overlap?) or if the packet is out-of-order, the whole data fragment and
follow_record_t structure was leaked. Found by Clang Static Analyzer.
Change-Id: I81dc7749c738938b14d2cf4ad41e624b15099da6
Fixes: v2.3.0rc0-1449-g66fa31415f ("tcp: Fix Follow TCP tap data and when its tapped.")
Reviewed-on: https://code.wireshark.org/review/27348
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Dario Lombardo <lomato@xxxxxxxxx>
(cherry picked from commit 4c14ac075403e3f5ea5709501918c08e45272439)
Reviewed-on: https://code.wireshark.org/review/27368
Actions performed:
from 8201772 nettrace_3gpp_32_423: fix memleak and copy of uninitialized memory
adds b08022e tcp: fix memleak in Follow TCP tap in error cases
Summary of changes:
epan/dissectors/packet-tcp.c | 6 ++++++
1 file changed, 6 insertions(+)