URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=a0d212b238120e21955f78a46c66376dd3530639
Submitter: Peter Wu (peter@xxxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark
Commits:
a0d212b by Peter Wu (peter@xxxxxxxxxxxxx):
prefs: fix crash when setting certain obsolete port preferences
Loading an old Wireshark profile with certain deprecated preferences
could result in a crash due to type confusion. If the new preference was
a range type, then four bytes of the pointer (address) to the range was
overwritten with the numeric value of the deprecated preference.
Minimal reproducer:
tshark -opgm.udp.encap_ucast_port:0 -r ../test/captures/empty.pcap
Bug: 14316
Change-Id: Ia8dc24f81f6b2e6494448dadffe810606765cb9e
Fixes: v2.3.0rc0-971-g268841f3e0 ("Combine Decode As and port preferences for tcp.port dissector table.")
Reviewed-on: https://code.wireshark.org/review/27226
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
(cherry picked from commit 2ed9115a4b4bca00721ec1d40018835b3e844f84)
[Peter: contextual conflict, automerged]
Reviewed-on: https://code.wireshark.org/review/27238
Reviewed-by: Peter Wu <peter@xxxxxxxxxxxxx>
Actions performed:
from 6fe7632 LDSS: Fix a read overrun in dissect_ldss_transfer.
adds a0d212b prefs: fix crash when setting certain obsolete port preferences
Summary of changes:
epan/prefs.c | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)