URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=735cfc8502e6dac8edfeb729e8c912ed897cb08b
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
735cfc8 by Guy Harris (guy@xxxxxxxxxxxx):
Clean up option handling.
If the option length is >= 2, so that it's long enough to include the
code and length, always put it into the protocol tree, even if the
length is invalid. If the length is invalid, attach an expert info item
to the length field, rather than putting it into a top-level item of its
own.
Use a length of -1 for the top-level item for an option, rather than
what the length is supposed to be; that way, we don't throw an exception
if the option is too short - we just attach the aforementioned expert
info item to the length.
Change-Id: If2d987fa10739a7da28ca2c39515bfdf50da6ef9
Reviewed-on: https://code.wireshark.org/review/27018
Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
Actions performed:
from d5c4c69 Fix tapo.
adds 735cfc8 Clean up option handling.
Summary of changes:
epan/dissectors/packet-tcp.c | 259 ++++++++++++++++++++++---------------------
1 file changed, 132 insertions(+), 127 deletions(-)