Wireshark-commits: [Wireshark-commits] master ccff218: Forbid leading, duplicated and trailing dots

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 16 Apr 2018 15:44:18 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ccff21854d5e340af3e8db3ecde555a20ce1f7d8
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ccff218 by Peter Wu (peter@xxxxxxxxxxxxx):

    Forbid leading, duplicated and trailing dots in field names
    
    In order to simplify the display filter scanner, try to restrict the use
    of dots ('.') in field names. Forbid leading dots, does not affect
    current dissectors. Fix '..' typo in fpp dissector and forbid it. Forbid
    trailing dots after fixing dissectors: some of them just have an excess
    dot, others are missing a name after the dot.
    
    Change-Id: I6e58a04ef0306ee8c16fbf6a3cabb076d7fc69c9
    Reviewed-on: https://code.wireshark.org/review/26967
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  f9ed587   ssl: fix duplicate dissections with multiple PDUs in a stream
    adds  ccff218   Forbid leading, duplicated and trailing dots in field names


Summary of changes:
 epan/dissectors/asn1/ldap/packet-ldap-template.c |  2 +-
 epan/dissectors/packet-bootp.c                   |  2 +-
 epan/dissectors/packet-btatt.c                   | 12 +--
 epan/dissectors/packet-bthci_vendor.c            |  2 +-
 epan/dissectors/packet-fpp.c                     |  8 +-
 epan/dissectors/packet-gtpv2.c                   |  4 +-
 epan/dissectors/packet-idrp.c                    |  4 +-
 epan/dissectors/packet-ldap.c                    |  2 +-
 epan/dissectors/packet-nfapi.c                   |  6 +-
 epan/dissectors/packet-obex.c                    |  2 +-
 epan/dissectors/packet-reload.c                  |  4 +-
 epan/dissectors/packet-ses.c                     |  2 +-
 epan/dissectors/packet-srvloc.c                  |  2 +-
 epan/dissectors/packet-umts_fp.c                 |  4 +-
 epan/dissectors/packet-zbee-zcl-general.c        | 28 +++----
 epan/proto.c                                     | 94 ++++++++++++------------
 plugins/epan/wimaxmacphy/packet-wimaxmacphy.c    |  2 +-
 17 files changed, 91 insertions(+), 89 deletions(-)