Wireshark-commits: [Wireshark-commits] master-2.2 4ac70ca: Need to flag a variable as volatile, due

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Thu, 12 Apr 2018 02:29:35 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4ac70ca529920a9fac3d5742ec4a30ed58b3258d
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.2
Repository: wireshark

Commits:

4ac70ca by Guy Harris (guy@xxxxxxxxxxxx):

    Need to flag a variable as volatile, due to the use of exceptions.
    
    The exception mechanism is setjmp/longjmp-based, so we need to mark
    offset as volatile, otherwise the longjmp might not restore its value.
    
    Change-Id: Ib63070bbbbe1f16a93cb58aa7ee5ef2a5488df8a
    Reviewed-on: https://code.wireshark.org/review/26901
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit 148f39d900b516cac575d7de689a44545a663c70)
    Reviewed-on: https://code.wireshark.org/review/26904
    

Actions performed:

    from  0416a3b   If a subdissector throws an exception, catch it and continue.
    adds  4ac70ca   Need to flag a variable as volatile, due to the use of exceptions.


Summary of changes:
 epan/dissectors/packet-mp2t.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)