Wireshark-commits: [Wireshark-commits] master-2.4 171e846: NBSS: take into account snaplen when cre

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Wed, 11 Apr 2018 09:53:28 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=171e846e4b42616eff79653d5507796c1907918e
Submitter: Pascal Quantin (pascal.quantin@xxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

171e846 by Pascal Quantin (pascal.quantin@xxxxxxxxx):

    NBSS: take into account snaplen when creating the TVB subset
    
    Otherwise you can trigger an exception interrupting the packet dissection
    when the snaplen defined is shorter than the payload length
    
    Bug: 14598
    Change-Id: Ibeb6482495ed67c7669574bdcd7c429523318428
    Reviewed-on: https://code.wireshark.org/review/26858
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Petri-Dish: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Martin Kaiser <wireshark@xxxxxxxxx>
    (cherry picked from commit 526a328d839cebf8d52dfcfdd479f12e83a28d3a)
    Reviewed-on: https://code.wireshark.org/review/26882
    

Actions performed:

    from  448f16a   user_encap: Avoid a hash lookup to get dissector name
    adds  171e846   NBSS: take into account snaplen when creating the TVB subset


Summary of changes:
 epan/dissectors/packet-nbt.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)