Wireshark-commits: [Wireshark-commits] master c7970d9: Add, and use, "fetch signed value" for lengt

From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 Apr 2018 14:55:55 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=c7970d9356a494d847101c2bd92e4ca97a7d3d58
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

c7970d9 by Guy Harris (guy@xxxxxxxxxxxx):

    Add, and use, "fetch signed value" for lengths < 40 bits.
    
    Add 8-bit, 16-bit, 24-bit, and 32-bit "fetch signed value" routines, and
    use them rather than casting the result of the 8/16/24/32-bit "fetch
    unsigned value" routines to a signed type (which, BTW, isn't sufficient
    for 24-bit values, so this appears to fix a bug
    in epan/dissectors/packet-zbee-zcl.c).
    
    Use numbers rather than sizeof()s in various tvb_get_ routines.
    
    Change-Id: I0e48a57fac9f70fe42de815c3fa915f1592548bd
    Reviewed-on: https://code.wireshark.org/review/26844
    Petri-Dish: Guy Harris <guy@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    

Actions performed:

    from  2cb93e2   NR (5G) PDCP
    adds  c7970d9   Add, and use, "fetch signed value" for lengths < 40 bits.


Summary of changes:
 epan/dissectors/packet-amqp.c               |  22 ++--
 epan/dissectors/packet-bacapp.c             |   8 +-
 epan/dissectors/packet-bootp.c              |   2 +-
 epan/dissectors/packet-btatt.c              |  12 +--
 epan/dissectors/packet-btbredr_rf.c         |   6 +-
 epan/dissectors/packet-ceph.c               |   2 +-
 epan/dissectors/packet-cp2179.c             |   4 +-
 epan/dissectors/packet-dns.c                |   2 +-
 epan/dissectors/packet-ecmp.c               |  16 +--
 epan/dissectors/packet-iec104.c             |   5 +-
 epan/dissectors/packet-ieee80211-radiotap.c |   4 +-
 epan/dissectors/packet-ieee80211.c          |   8 +-
 epan/dissectors/packet-ixveriwave.c         |  18 ++--
 epan/dissectors/packet-lbmpdm.c             |   4 +-
 epan/dissectors/packet-lbmr.c               |   2 +-
 epan/dissectors/packet-lldp.c               |   8 +-
 epan/dissectors/packet-ntp.c                |   4 +-
 epan/dissectors/packet-ossp.c               |   2 +-
 epan/dissectors/packet-ppi.c                |   4 +-
 epan/dissectors/packet-synphasor.c          |   6 +-
 epan/dissectors/packet-ubertooth.c          |  10 +-
 epan/dissectors/packet-zbee-zcl-misc.c      |   6 +-
 epan/dissectors/packet-zbee-zcl.c           |   8 +-
 epan/proto.c                                |  22 ++--
 epan/tvbuff.c                               | 159 ++++++++++++++++++++++++----
 epan/tvbuff.h                               |  13 +++
 epan/wslua/wslua_tvb.c                      |  48 ++++-----
 plugins/epan/wimax/msg_fpc.c                |   2 +-
 plugins/epan/wimax/msg_pmc.c                |   2 +-
 29 files changed, 268 insertions(+), 141 deletions(-)