Wireshark-commits: [Wireshark-commits] master 7c3f848: The message length is unsigned, not signed;

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 10 Apr 2018 05:35:47 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7c3f8484ecf436c121fce890a70be22b3da80e23
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

7c3f848 by Guy Harris (guy@xxxxxxxxxxxx):

    The message length is unsigned, not signed; treat it as such.
    
    Add explicit checks for values that don't fit in a gint, rather than
    relying on testing for < 1 catching that case.
    
    Change-Id: I4181087e3499537da88117b710d56c6b5fe9ceaa
    Reviewed-on: https://code.wireshark.org/review/26843
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    

Actions performed:

    from  70a1d1c   Get rid of get_opaque_length() and unneeded length arguments.
    adds  7c3f848   The message length is unsigned, not signed; treat it as such.


Summary of changes:
 epan/dissectors/packet-m2pa.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)