Wireshark-commits: [Wireshark-commits] master-2.6 9303d85: ws_pipe: Zero an array.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 09 Apr 2018 08:27:55 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=9303d8502bc957357d6cd09e78c0141905da0664
Submitter: Anders Broman (a.broman58@xxxxxxxxx)
Changed: branch: master-2.6
Repository: wireshark

Commits:

9303d85 by Gerald Combs (gerald@xxxxxxxxxxxxx):

    ws_pipe: Zero an array.
    
    Make sure we zero-initialize pipeinsts, otherwise ConnectNamedPipe will
    have indeterminate behavior according to the MSDN documentation for the
    OVERLAPPED structure.
    
    Change-Id: I38d9680cf01b0a8f9e566a85a7a330f6c0aa9a48
    Ping-Bug: 14532
    Reviewed-on: https://code.wireshark.org/review/26784
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Anders Broman <a.broman58@xxxxxxxxx>
    (cherry picked from commit ffe2f138ab62c48467645a953fb0617bf2f1b39b)
    Reviewed-on: https://code.wireshark.org/review/26813
    

Actions performed:

    from  d0da2d5   main window: don't keep a dangling freeze_focus_ pointer
    adds  9303d85   ws_pipe: Zero an array.


Summary of changes:
 wsutil/ws_pipe.c | 2 ++
 1 file changed, 2 insertions(+)