Wireshark-commits: [Wireshark-commits] master ba55c82: pdcp-lte: Various improvements spotted while

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Fri, 06 Apr 2018 16:24:13 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=ba55c82842a6e20c90ae924e1dc8f30f2b763474
Submitter: Martin Mathieson (martin.r.mathieson@xxxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

ba55c82 by Martin Mathieson (martin.r.mathieson@xxxxxxxxxxxxxx):

    pdcp-lte:  Various improvements spotted while reviewing pdcp-nr.
    
    Prune list of possible ROHC modes.
    Avoid separately extracting lots of values, instead use _ret_uint variant while adding item.
    
    Change-Id: I8d75fe670fe02f1ae6c1da34b3ac6e0a22a0b894
    Reviewed-on: https://code.wireshark.org/review/26777
    Petri-Dish: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Pascal Quantin <pascal.quantin@xxxxxxxxx>
    Reviewed-by: Martin Mathieson <martin.r.mathieson@xxxxxxxxxxxxxx>
    

Actions performed:

    from  64d6a7b   NR RRC: upgrade dissector to v15.1.0
    adds  ba55c82   pdcp-lte:  Various improvements spotted while reviewing pdcp-nr.


Summary of changes:
 epan/dissectors/packet-pdcp-lte.c | 157 ++++++++++++++------------------------
 1 file changed, 57 insertions(+), 100 deletions(-)