URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=7c0c8189a6b9dd7f67c165b694e0384b0682086e
Submitter: Alexis La Goutte (alexis.lagoutte@xxxxxxxxx)
Changed: branch: master
Repository: wireshark
Commits:
7c0c818 by Peter Wu (peter@xxxxxxxxxxxxx):
Qt: fix "Follow stream" in Conversations dialog
If no stream is given to FollowStreamDialog::follow(), then it
overwrites the display filter with a conversation filter for the first
packet in the capture file.
Pass an explicit stream number and the "Follow stream" button will set a
correct display filter.
Test: open pcap with three TCP streams. Statistics -> Conversations.
Select last TCP conversation (expect "tcp.stream eq 2"). Select the
second conversation (expect "tcp.stream eq 1") and activate "Filter Out"
button (expect "!(tcp.stream eq 1)" and not "!(tcp.stream eq 2) and
!(tcp.stream eq 1)").
Bug: 14254
Change-Id: I28744d7f76f5034b07ea5660b45399566e3a7d2c
Reviewed-on: https://code.wireshark.org/review/26520
Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
Tested-by: Petri Dish Buildbot
Reviewed-by: Alexis La Goutte <alexis.lagoutte@xxxxxxxxx>
Actions performed:
from 83d0287 GPRSCDR: fix bitrates in EPCQoSInformation
adds 7c0c818 Qt: fix "Follow stream" in Conversations dialog
Summary of changes:
ui/qt/conversation_dialog.cpp | 14 ++++----------
ui/qt/conversation_dialog.h | 2 +-
ui/qt/main_window.h | 2 +-
ui/qt/main_window_slots.cpp | 14 ++++++++++----
4 files changed, 16 insertions(+), 16 deletions(-)