Wireshark-commits: [Wireshark-commits] master 246f0bc: Get rid of TestBigEndian and AC_C_BIGENDIAN.

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Tue, 13 Mar 2018 19:09:46 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=246f0bc0125eb2137781f5f8bfad783a2f7ac4cd
Submitter: Gerald Combs (gerald@xxxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

246f0bc by Gerald Combs (gerald@xxxxxxxxxxxxx):

    Get rid of TestBigEndian and AC_C_BIGENDIAN.
    
    Get rid of CMake's TestBigEndian and Autotools' AC_C_BIGENDIAN checks in
    favor of G_BYTE_ORDER. We use G_BYTE_ORDER elsewhere and TestBigEndian
    is noticeably slow on Windows.
    
    Change-Id: Idc1326294db9cbee8f6b6b11c2028fc4d19acbf0
    Reviewed-on: https://code.wireshark.org/review/26462
    Petri-Dish: Gerald Combs <gerald@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Gerald Combs <gerald@xxxxxxxxxxxxx>
    

Actions performed:

    from  fa27833   Removed assert which was only used for debugging.
    adds  246f0bc   Get rid of TestBigEndian and AC_C_BIGENDIAN.


Summary of changes:
 CMakeLists.txt      | 4 ----
 cmakeconfig.h.in    | 4 ----
 configure.ac        | 3 ---
 epan/tvbuff.c       | 4 ++--
 text2pcap.c         | 4 ++--
 wiretap/lanalyzer.c | 2 +-
 wiretap/netmon.c    | 4 ++--
 7 files changed, 7 insertions(+), 18 deletions(-)