Wireshark-commits: [Wireshark-commits] master-2.4 12b83f8: eth: fix null pointer dereference when c

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Mon, 12 Mar 2018 04:50:33 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=12b83f8eb095188e2a0c1097024f6fc16a7cbbc6
Submitter: Guy Harris (guy@xxxxxxxxxxxx)
Changed: branch: master-2.4
Repository: wireshark

Commits:

12b83f8 by Peter Wu (peter@xxxxxxxxxxxxx):

    eth: fix null pointer dereference when called from Lua
    
    At the moment, Lua dissectors always pass a NULL data parameter, so
    dissectors like eth should gracefully handle that.
    
    Bug: 14293
    Change-Id: Ida4d0530a9c417db5960475274315d4acc3704a8
    Fixes: v2.1.0rc0-1575-g8ec153f938 ("Have the "maybe an FCS" version of the Ethernet dissector take a data argument.")
    Reviewed-on: https://code.wireshark.org/review/26431
    Petri-Dish: Peter Wu <peter@xxxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Guy Harris <guy@xxxxxxxxxxxx>
    (cherry picked from commit ba179a7ef7e660d788cbaade65982ffc7249b91f)
    Reviewed-on: https://code.wireshark.org/review/26435
    

Actions performed:

    from  af8ffd7   [Automatic update for 2018-03-11]
    adds  12b83f8   eth: fix null pointer dereference when called from Lua


Summary of changes:
 epan/dissectors/packet-eth.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)