Wireshark-commits: [Wireshark-commits] master 2ecb33c: ENIP packets are not decoded as ENIP anymore

Date Prev · Date Next · Thread Prev · Thread Next
Date Index · Thread Index · Other Months · All Mailing Lists
From: Wireshark code review <code-review-do-not-reply@xxxxxxxxxxxxx>
Date: Sat, 10 Mar 2018 21:13:02 +0000
URL: https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=2ecb33c039d75d851bb4fc4e72c8f8a389c9ab55
Submitter: Michael Mann (mmann78@xxxxxxxxxxxx)
Changed: branch: master
Repository: wireshark

Commits:

2ecb33c by Dylan Ulis (daulis0@xxxxxxxxx):

    ENIP packets are not decoded as ENIP anymore
    
    The length check in dissect_enip_tcp() was previously removed but
    it's necessary to filter out one byte messages that are mostly likely
    TCP keep alives.
    
    Bug: 14434
    
    Change-Id: I44c10aaf0a2e06870ad82f87aab9d72548b77f9f
    Reviewed-on: https://code.wireshark.org/review/25807
    Petri-Dish: Michael Mann <mmann78@xxxxxxxxxxxx>
    Tested-by: Petri Dish Buildbot
    Reviewed-by: Michael Mann <mmann78@xxxxxxxxxxxx>
    

Actions performed:

    from  6a819d9   MaxMindDB: Add country ISO codes.
    adds  2ecb33c   ENIP packets are not decoded as ENIP anymore


Summary of changes:
 epan/dissectors/packet-enip.c | 9 +++++++++
 1 file changed, 9 insertions(+)